[Enhancement] Convert Params Models To Dictionary Before Assigning As Private Attribute In OBBject. #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
…ance/OpenBBTerminal into feature/params-model-to-dict
hjoaquim
reviewed
Jun 12, 2024
openbb_platform/obbject_extensions/charting/openbb_charting/__init__.py
Outdated
Show resolved
Hide resolved
hjoaquim
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
^^
Every process downstream accessing this private attribute converts to a dictionary immediately, so this does the job once instead of repeating in multiple places.
What?:
obbject._standard_paramsis now a dictionary.openbb-chartinginit to reflect the change.Impact:
Testing Done: